RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-04-01 23:02:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

OSD: pg might be removed during disconnect_session_watches

Browse Source 
We don't hold the osd_lock between the session->watches traversal
and the obc checks.

Signed-off-by: Samuel Just <sam.just@inktank.com>
This commit is contained in:
Samuel Just 2012-12-12 15:09:25 -08:00
parent 047aecd90f
commit dba096073a
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/osd/OSD.cc
View File

@ -2431,7 +2431,12 @@ void OSD::disconnect_session_watches(Session *session)
dout(10) << "obc=" << (void *)obc << dendl;
ReplicatedPG *pg = static_cast<ReplicatedPG *>(lookup_lock_raw_pg(oiter->second));
assert(pg);
if (!pg) {
/* pg removed between watch_unlock.Unlock() and now, all related
* watch structures would have been cleaned up in remove_watchers_and_notifies
*/
continue;
}
service.watch_lock.Lock();
/* NOTE! fix this one, should be able to just lookup entity name,
however, we currently only keep EntityName on the session and not