qa: do not cleanup sandbox on error

Otherwise the command will hang if the mount is broken.

Fixes: http://tracker.ceph.com/issues/36184
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
This commit is contained in:
Patrick Donnelly 2018-09-26 07:38:58 -07:00
parent bdd2ddcfd8
commit d4b8f94cf8
No known key found for this signature in database
GPG Key ID: 3A2A7E25BEA8AADB

View File

@ -414,9 +414,7 @@ def _run_tests(ctx, refspec, role, tests, env, basedir,
finally:
log.info('Stopping %s on %s...', tests, role)
args=['sudo', 'rm', '-rf', '--', workunits_file, clonedir]
if cleanup:
log.info("and cleaning up scratch: {}".format(scratch_tmp))
args.append(scratch_tmp)
# N.B. don't cleanup scratch_tmp! If the mount is broken then rm will hang.
remote.run(
logger=log.getChild(role),
args=args,