mon: add mon_warn_on_misplaced option

Control whether we issue HEALTH_WARN due to misplaced objects.

Signed-off-by: Sage Weil <sage@redhat.com>
This commit is contained in:
Sage Weil 2018-11-16 11:00:52 -06:00
parent ed5b7e779d
commit d4a65456ce
3 changed files with 7 additions and 1 deletions

View File

@ -257,6 +257,7 @@ OPTION(mon_crush_min_required_version, OPT_STR)
OPTION(mon_warn_on_crush_straw_calc_version_zero, OPT_BOOL) // warn if crush straw_calc_version==0
OPTION(mon_warn_on_osd_down_out_interval_zero, OPT_BOOL) // warn if 'mon_osd_down_out_interval == 0'
OPTION(mon_warn_on_cache_pools_without_hit_sets, OPT_BOOL)
OPTION(mon_warn_on_misplaced, OPT_BOOL)
OPTION(mon_min_osdmap_epochs, OPT_INT)
OPTION(mon_max_pgmap_epochs, OPT_INT)
OPTION(mon_max_log_epochs, OPT_INT)

View File

@ -1523,6 +1523,10 @@ std::vector<Option> get_global_options() {
.set_default(true)
.set_description("Enable POOL_APP_NOT_ENABLED health check"),
Option("mon_warn_on_misplaced", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
.set_default(true)
.set_description("Issue a health warning if there are misplaced objects"),
Option("mon_max_snap_prune_per_epoch", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
.set_default(100)
.set_description("Max number of pruned snaps we will process in a single OSDMap epoch"),

View File

@ -2732,7 +2732,8 @@ void PGMap::get_health_checks(
// OBJECT_MISPLACED
if (pg_sum.stats.sum.num_objects_misplaced &&
pg_sum.stats.sum.num_object_copies > 0) {
pg_sum.stats.sum.num_object_copies > 0 &&
cct->_conf->mon_warn_on_misplaced) {
double pc = (double)pg_sum.stats.sum.num_objects_misplaced /
(double)pg_sum.stats.sum.num_object_copies * (double)100.0;
char b[20];