From cdbc18254dc3597f09be812a828c3be331754469 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Wed, 10 Oct 2018 15:54:34 -0400 Subject: [PATCH] rgw: remove RGWPutObj::select_processor Signed-off-by: Casey Bodley --- src/rgw/rgw_op.cc | 28 ---------------------------- src/rgw/rgw_op.h | 5 ----- 2 files changed, 33 deletions(-) diff --git a/src/rgw/rgw_op.cc b/src/rgw/rgw_op.cc index dacc324e872..81eea2e1fd4 100644 --- a/src/rgw/rgw_op.cc +++ b/src/rgw/rgw_op.cc @@ -3388,34 +3388,6 @@ int RGWPutObjProcessor_Multipart::do_complete(size_t accounted_size, return r; } -RGWPutObjProcessor *RGWPutObj::select_processor(RGWObjectCtx& obj_ctx, bool *is_multipart) -{ - RGWPutObjProcessor *processor; - - bool multipart = s->info.args.exists("uploadId"); - - uint64_t part_size = s->cct->_conf->rgw_obj_stripe_size; - - if (!multipart) { - processor = new RGWPutObjProcessor_Atomic(obj_ctx, s->bucket_info, s->bucket, s->object.name, part_size, s->req_id, s->bucket_info.versioning_enabled()); - (static_cast(processor))->set_olh_epoch(olh_epoch); - (static_cast(processor))->set_version_id(version_id); - } else { - processor = new RGWPutObjProcessor_Multipart(obj_ctx, s->bucket_info, part_size, s); - } - - if (is_multipart) { - *is_multipart = multipart; - } - - return processor; -} - -void RGWPutObj::dispose_processor(RGWPutObjDataProcessor *processor) -{ - delete processor; -} - void RGWPutObj::pre_exec() { rgw_bucket_object_pre_exec(s); diff --git a/src/rgw/rgw_op.h b/src/rgw/rgw_op.h index 00d1978f28c..61428021c82 100644 --- a/src/rgw/rgw_op.h +++ b/src/rgw/rgw_op.h @@ -995,9 +995,6 @@ struct RGWSLOInfo { WRITE_CLASS_ENCODER(RGWSLOInfo) class RGWPutObj : public RGWOp { - - friend class RGWPutObjProcessor; - protected: seed torrent; off_t ofs; @@ -1061,8 +1058,6 @@ public: attrs.emplace(std::move(key), std::move(bl)); /* key and bl are r-value refs */ } - virtual RGWPutObjProcessor *select_processor(RGWObjectCtx& obj_ctx, bool *is_multipart); - void dispose_processor(RGWPutObjDataProcessor *processor); int verify_permission() override; void pre_exec() override; void execute() override;