mirror of
https://github.com/ceph/ceph
synced 2025-02-25 03:52:04 +00:00
ceph: valgrind trumps coverage when picking a flavor
valgrind will crash if we don't use notcmalloc; coverage will silently fail to collect coverage info.
This commit is contained in:
parent
5216d3c7a9
commit
c5688e6570
@ -961,13 +961,13 @@ def task(ctx, config):
|
||||
# local dir precludes any other flavors
|
||||
flavor = ['local']
|
||||
else:
|
||||
if config.get('coverage'):
|
||||
log.info('Recording coverage for this run.')
|
||||
flavor.append('gcov')
|
||||
if config.get('valgrind'):
|
||||
log.info('Using notcmalloc flavor and running some daemons under valgrind')
|
||||
flavor.append('notcmalloc')
|
||||
else:
|
||||
if config.get('valgrind'):
|
||||
log.info('Using notcmalloc flavor and running some daemons under valgrind')
|
||||
flavor.append('notcmalloc')
|
||||
if config.get('coverage'):
|
||||
log.info('Recording coverage for this run.')
|
||||
flavor.append('gcov')
|
||||
|
||||
flavor = '-'.join(flavor)
|
||||
if flavor == '':
|
||||
|
Loading…
Reference in New Issue
Block a user