RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-29 22:43:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

cls/rbd/cls_rbd.cc: use !empty() instead of 'size() > 0'

Browse Source 
Use empty() since it should be prefered as it has, following the
standard, a constant time complexity regardless of the containter
type. The same is not guaranteed for size().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
This commit is contained in:
Danny Al-Gaaf 2013-02-13 16:49:53 +01:00 committed by Greg Farnum
parent fb811ecff8
commit c4f1c0799f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cls/rbd/cls_rbd.cc
View File

@ -1116,7 +1116,7 @@ int get_snapcontext(cls_method_context_t hctx, bufferlist *in, bufferlist *out)
snapid_t snap_id = snap_id_from_key(*it);
snap_ids.push_back(snap_id);
}
if (keys.size() > 0)
if (!keys.empty())
last_read = *(keys.rbegin());
} while (r == max_read);
@ -1269,7 +1269,7 @@ int snapshot_add(cls_method_context_t hctx, bufferlist *in, bufferlist *out)
}
}
if (vals.size() > 0)
if (!vals.empty())
last_read = vals.rbegin()->first;
} while (r == RBD_MAX_KEYS_READ);
@ -1717,7 +1717,7 @@ int dir_list(cls_method_context_t hctx, bufferlist *in, bufferlist *out)
if (images.size() >= max_return)
break;
}
if (vals.size() > 0) {
if (!vals.empty()) {
last_read = dir_key_for_name(images.rbegin()->first);
}
}