RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2024-12-17 17:05:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16013 from xiexingguo/wip-blue-tool

Browse Source 
os/bluestore/bluestore_tool: add sanity check to get rid of occasionally crash

Reviewed-by: Sage Weil <sage@redhat.com>
This commit is contained in:
Sage Weil 2017-07-26 10:04:26 -05:00 committed by GitHub
commit c4ee3a5d17
1 changed files with 81 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

106
src/os/bluestore/bluestore_tool.cc
View File

@ -25,6 +25,46 @@ void usage(po::options_description &desc)
cout << desc << std::endl;
}
void validate_path(CephContext *cct, const string& path, bool bluefs)
{
BlueStore bluestore(cct, path);
string type;
int r = bluestore.read_meta("type", &type);
if (r < 0) {
cerr << "failed to load os-type: " << cpp_strerror(r) << std::endl;
exit(EXIT_FAILURE);
}
if (type != "bluestore") {
cerr << "expected bluestore, but type is " << type << std::endl;
exit(EXIT_FAILURE);
}
if (!bluefs) {
return;
}
string kv_backend;
r = bluestore.read_meta("kv_backend", &kv_backend);
if (r < 0) {
cerr << "failed to load kv_backend: " << cpp_strerror(r) << std::endl;
exit(EXIT_FAILURE);
}
if (kv_backend != "rocksdb") {
cerr << "expect kv_backend to be rocksdb, but is " << kv_backend
<< std::endl;
exit(EXIT_FAILURE);
}
string bluefs_enabled;
r = bluestore.read_meta("bluefs", &bluefs_enabled);
if (r < 0) {
cerr << "failed to load do_bluefs: " << cpp_strerror(r) << std::endl;
exit(EXIT_FAILURE);
}
if (bluefs_enabled != "1") {
cerr << "bluefs not enabled for rocksdb" << std::endl;
exit(EXIT_FAILURE);
}
}
int main(int argc, char **argv)
{
string out_dir;
@ -60,29 +100,28 @@ int main(int argc, char **argv)
po::include_positional);
} catch(po::error &e) {
std::cerr << e.what() << std::endl;
return 1;
exit(EXIT_FAILURE);
}
if (vm.count("help")) {
usage(po_all);
return 1;
exit(EXIT_SUCCESS);
}
if (action.empty()) {
cerr << "must specify an action; --help for help" << std::endl;
return 1;
exit(EXIT_FAILURE);
}
if (action == "fsck") {
if (path.empty()) {
cerr << "must specify bluestore path" << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
}
if (action == "bluefs-export" ||
action == "show-label") {
if (action == "show-label") {
if (devs.empty() && path.empty()) {
cerr << "must specify bluestore path *or* raw device(s)" << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
cout << "infering bluefs devices from bluestore path" << std::endl;
for (auto fn : {"block", "block.wal", "block.db"}) {
@ -93,6 +132,24 @@ int main(int argc, char **argv)
}
}
}
if (action == "bluefs-export") {
if (path.empty()) {
cerr << "must specify bluestore path" << std::endl;
exit(EXIT_FAILURE);
}
if (out_dir.empty()) {
cerr << "must specify out-dir to export bluefs" << std::endl;
exit(EXIT_FAILURE);
}
cout << "infering bluefs devices from bluestore path" << std::endl;
for (auto fn : {"block", "block.wal", "block.db"}) {
string p = path + "/" + fn;
struct stat st;
if (::stat(p.c_str(), &st) == 0) {
devs.push_back(p);
}
}
}
vector<const char*> args;
for (auto& i : ceph_option_strings) {
@ -108,11 +165,12 @@ int main(int argc, char **argv)
if (action == "fsck" ||
action == "fsck-deep") {
validate_path(cct.get(), path, false);
BlueStore bluestore(cct.get(), path);
int r = bluestore.fsck(fsck_deep);
if (r < 0) {
cerr << "error from fsck: " << cpp_strerror(r) << std::endl;
return 1;
exit(EXIT_FAILURE);
}
}
else if (action == "show-label") {
@ -124,7 +182,7 @@ int main(int argc, char **argv)
if (r < 0) {
cerr << "unable to read label for " << i << ": "
<< cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
jf.open_object_section(i.c_str());
label.dump(&jf);
@ -134,10 +192,7 @@ int main(int argc, char **argv)
jf.flush(cout);
}
else if (action == "bluefs-export") {
if (out_dir.empty()) {
cerr << "must specify out-dir to export bluefs" << std::endl;
exit(1);
}
validate_path(cct.get(), path, true);
BlueFS fs(&(*cct));
string main;
set<int> got;
@ -147,7 +202,7 @@ int main(int argc, char **argv)
if (r < 0) {
cerr << "unable to read label for " << i << ": "
<< cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
int id = -1;
if (label.description == "main")
@ -162,7 +217,7 @@ int main(int argc, char **argv)
int r = fs.add_block_device(id, i);
if (r < 0) {
cerr << "unable to open " << i << ": " << cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
}
}
@ -175,7 +230,7 @@ int main(int argc, char **argv)
if (r < 0) {
cerr << "unable to open " << main << ": " << cpp_strerror(r)
<< std::endl;
exit(1);
exit(EXIT_FAILURE);
}
}
@ -183,14 +238,14 @@ int main(int argc, char **argv)
if (r < 0) {
cerr << "unable to mount bluefs: " << cpp_strerror(r)
<< std::endl;
exit(1);
exit(EXIT_FAILURE);
}
vector<string> dirs;
r = fs.readdir("", &dirs);
if (r < 0) {
cerr << "readdir in root failed: " << cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
for (auto& dir : dirs) {
if (dir[0] == '.')
@ -200,13 +255,14 @@ int main(int argc, char **argv)
r = fs.readdir(dir, &ls);
if (r < 0) {
cerr << "readdir " << dir << " failed: " << cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
string full = out_dir + "/" + dir;
r = ::mkdir(full.c_str(), 0755);
if (r < 0) {
r = -errno;
cerr << "mkdir " << full << " failed: " << cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
for (auto& file : ls) {
if (file[0] == '.')
@ -217,14 +273,14 @@ int main(int argc, char **argv)
r = fs.stat(dir, file, &size, &mtime);
if (r < 0) {
cerr << "stat " << file << " failed: " << cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
string path = out_dir + "/" + dir + "/" + file;
int fd = ::open(path.c_str(), O_CREAT|O_WRONLY|O_TRUNC, 0644);
if (fd < 0) {
r = -errno;
cerr << "open " << path << " failed: " << cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
assert(fd >= 0);
if (size > 0) {
@ -233,7 +289,7 @@ int main(int argc, char **argv)
if (r < 0) {
cerr << "open_for_read " << dir << "/" << file << " failed: "
<< cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
int pos = 0;
int left = size;
@ -243,13 +299,13 @@ int main(int argc, char **argv)
if (r <= 0) {
cerr << "read " << dir << "/" << file << " from " << pos
<< " failed: " << cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
int rc = bl.write_fd(fd);
if (rc < 0) {
cerr << "write to " << path << " failed: "
<< cpp_strerror(r) << std::endl;
exit(1);
exit(EXIT_FAILURE);
}
pos += r;
left -= r;