RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-19 08:57:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

msg/DispatchQueue: fix message leak from discard_queue()

Browse Source 
We need to drop the Message ref() here; the msgr owns one ref
independent of those from the intrusive_ptr's in the queue itself.

Signed-off-by: Sage Weil <sage@inktank.com>
This commit is contained in:
Sage Weil 2012-11-17 16:36:44 -08:00
parent 183953e14b
commit c4caf871aa
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/msg/DispatchQueue.cc
View File

@ -127,8 +127,9 @@ void DispatchQueue::discard_queue(uint64_t id) {
i != removed.end();
++i) {
assert(!(i->is_code())); // We don't discard id 0, ever!
msgr->dispatch_throttle_release(
i->get_message()->get_dispatch_throttle_size());
Message *m = i->get_message();
msgr->dispatch_throttle_release(m->get_dispatch_throttle_size());
m->put();
}
}