RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-22 18:47:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

rbd: rbd-mirroring: Disable image mirroring when journaling feature is disabled

Browse Source 
Signed-off-by: Ricardo Dias <rdias@suse.com>
Fixes: #15143
This commit is contained in:
Ricardo Dias 2016-03-17 15:54:02 +00:00
parent ba6c0c9d4c
commit c472493659
1 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/librbd/internal.cc
View File

@ -1473,6 +1473,37 @@ int validate_mirroring_enabled(ImageCtx *ictx) {
disable_flags = RBD_FLAG_FAST_DIFF_INVALID;
}
if ((features & RBD_FEATURE_JOURNALING) != 0) {
rbd_mirror_mode_t mirror_mode;
r = librbd::mirror_mode_get(ictx->md_ctx, &mirror_mode);
if (r < 0) {
lderr(cct) << "error in retrieving pool mirroring status: "
<< cpp_strerror(r) << dendl;
return r;
}
if (mirror_mode == RBD_MIRROR_MODE_IMAGE) {
cls::rbd::MirrorImage mirror_image;
r = cls_client::mirror_image_get(&ictx->md_ctx, ictx->id,
&mirror_image);
if (r < 0 && r != -ENOENT) {
lderr(cct) << "error retrieving mirroring state: "
<< cpp_strerror(r) << dendl;
}
if (mirror_image.state ==
cls::rbd::MirrorImageState::MIRROR_IMAGE_STATE_ENABLED) {
lderr(cct) << "cannot disable journaling: image mirroring "
" enabled and mirror pool mode set to image" << dendl;
return -EINVAL;
}
} else if (mirror_mode == RBD_MIRROR_MODE_POOL) {
r = mirror_image_disable(ictx, false);
if (r < 0) {
lderr(cct) << "error disabling image mirroring: "
<< cpp_strerror(r) << dendl;
}
}
r = Journal<>::remove(ictx->md_ctx, ictx->id);
if (r < 0) {
lderr(cct) << "error removing image journal: " << cpp_strerror(r)