RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-03-11 02:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

librbd: init everything in default AioRequest constructors

Browse Source 
CID 717222: Uninitialized pointer field (UNINIT_CTOR)
At (16): Non-static class member "m_hide_enoent" is not initialized
in this constructor nor in any functions that it calls.

CID 717223: Uninitialized scalar field (UNINIT_CTOR)
At (4): Non-static class member "m_has_parent" is not initialized in
this constructor nor in any functions that it calls.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
This commit is contained in:
Josh Durgin 2012-09-24 13:19:59 -07:00
parent 3486050ddc
commit c1ffe08c18
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/librbd/AioRequest.cc
View File

@ -17,7 +17,10 @@
namespace librbd {
AioRequest::AioRequest() {}
AioRequest::AioRequest() :
m_ictx(NULL), m_image_ofs(0), m_block_ofs(0), m_len(0),
m_snap_id(CEPH_NOSNAP), m_completion(NULL), m_parent_completion(NULL),
m_hide_enoent(false) {}
AioRequest::AioRequest(ImageCtx *ictx, const std::string &oid,
uint64_t image_ofs, size_t len,
librados::snap_t snap_id,
@ -95,7 +98,8 @@ namespace librbd {
return r;
}
AbstractWrite::AbstractWrite() {}
AbstractWrite::AbstractWrite() :
m_state(LIBRBD_AIO_WRITE_FINAL), m_has_parent(false) {}
AbstractWrite::AbstractWrite(ImageCtx *ictx, const std::string &oid,
uint64_t image_ofs, size_t len,
librados::snap_t snap_id, Context *completion,