diff --git a/src/ceph-detect-init/ceph_detect_init/debian/__init__.py b/src/ceph-detect-init/ceph_detect_init/debian/__init__.py index 59b47816f47..b5fc7c774e6 100644 --- a/src/ceph-detect-init/ceph_detect_init/debian/__init__.py +++ b/src/ceph-detect-init/ceph_detect_init/debian/__init__.py @@ -8,6 +8,7 @@ def choose_init(): Returns the name of a init system (upstart, sysvinit ...). """ + assert(distro and codename) if distro.lower() in ('ubuntu', 'linuxmint'): if codename >= 'vivid': return 'systemd' diff --git a/src/ceph-detect-init/tests/test_all.py b/src/ceph-detect-init/tests/test_all.py index 4c408f9b507..f444eebb9f7 100644 --- a/src/ceph-detect-init/tests/test_all.py +++ b/src/ceph-detect-init/tests/test_all.py @@ -44,15 +44,18 @@ class TestCephDetectInit(testtools.TestCase): self.assertEqual('sysvinit', centos.choose_init()) def test_debian(self): - with mock.patch('ceph_detect_init.debian.distro', - 'debian'): + with mock.patch.multiple('ceph_detect_init.debian', + distro='debian', + codename='wheezy'): self.assertEqual('sysvinit', debian.choose_init()) - with mock.patch('ceph_detect_init.debian.distro', - 'ubuntu'): + with mock.patch.multiple('ceph_detect_init.debian', + distro='ubuntu', + codename='trusty'): self.assertEqual('upstart', debian.choose_init()) - with mock.patch('ceph_detect_init.debian.codename', - 'vivid'): - self.assertEqual('systemd', debian.choose_init()) + with mock.patch.multiple('ceph_detect_init.debian', + distro='ubuntu', + codename='vivid'): + self.assertEqual('systemd', debian.choose_init()) def test_fedora(self): with mock.patch('ceph_detect_init.fedora.release',