RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-20 10:01:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

mgr/diskprediction_local: import scipy early to fix self-test deadlock

Browse Source 
We are seeing a hang on centos7 (but not ubuntu 18.04) from

        from .predictor import get_diskfailurepredictor_path

in _predict_life_expentancy.

Doing that same predictor import at the top of the file doesn't help--it
hangs right when the diskpredictor_local module is loaded.  Commenting
out the import scipy in predictor.py avoids the hang.

I'm not sure why, but doing the full scipy import here appears to work
around the problem.

Fixes: https://tracker.ceph.com/issues/42764
Signed-off-by: Sage Weil <sage@redhat.com>
This commit is contained in:
Sage Weil 2019-12-07 15:34:59 -06:00
parent b35dbcd582
commit b9dea87ff1
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pybind/mgr/diskprediction_local/module.py
View File

@ -9,6 +9,14 @@ import time
from mgr_module import MgrModule, CommandResult
# Importing scipy early appears to avoid a future deadlock when
# we try to do
#
# from .predictor import get_diskfailurepredictor_path
#
# in a command thread. See https://tracker.ceph.com/issues/42764
import scipy
TIME_FORMAT = '%Y%m%d-%H%M%S'
TIME_DAYS = 24*60*60