RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-01 08:32:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

test/librados_test_stub: add IoCtx::{set,get}_pool_full_try() stubs

Browse Source 
Because unittest_librbd links not just with librados_test_stub.a but
also with librados.so (why?), these were sneakily picked up from the
latter.  This resulted in get_pool_full_try() reading from invalid
memory and every once in a while returning true, prompting librbd to
write to invalid memory through set_pool_full_try() in create_ioctx()
and cause random crashes.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Ilya Dryomov 2021-10-17 13:09:14 +02:00
parent 7cc7efae2a
commit b387fdeeb3
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/test/librados_test_stub/LibradosTestStub.cc
View File

@ -791,6 +791,13 @@ std::string IoCtx::get_namespace() const {
return ctx->get_namespace(); return ctx->get_namespace();
} }
void IoCtx::set_pool_full_try() {
}
bool IoCtx::get_pool_full_try() {
return false;
}
static int save_operation_result(int result, int *pval) { static int save_operation_result(int result, int *pval) {
if (pval != NULL) { if (pval != NULL) {
*pval = result; *pval = result;