RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2024-12-18 09:25:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix mismatched sign comparison in histogram test

Browse Source 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
This commit is contained in:
Adam C. Emerson 2017-02-10 13:50:58 -05:00
parent 880cbf09aa
commit ae43b774a4
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/test/common/test_perf_histogram.cc
View File

@ -94,28 +94,28 @@ TEST(PerfHistogram, ZeroedInitially) {
PerfHistogramAccessor<2> h{x_axis, y_axis};
for (int x = 0; x < XS; ++x) {
for (int y = 0; y < YS; ++y) {
ASSERT_EQ(0, h.read_bucket(x, y));
ASSERT_EQ(0UL, h.read_bucket(x, y));
}
}
}
TEST(PerfHistogram, SimpleValues) {
PerfHistogramAccessor<2> h{x_axis, y_axis};
ASSERT_EQ(0, h.read_bucket(1, 1));
ASSERT_EQ(0UL, h.read_bucket(1, 1));
h.inc(0, 0);
ASSERT_EQ(1, h.read_bucket(1, 1));
ASSERT_EQ(1UL, h.read_bucket(1, 1));
ASSERT_EQ(0, h.read_bucket(2, 2));
ASSERT_EQ(0UL, h.read_bucket(2, 2));
h.inc(1, 1);
ASSERT_EQ(1, h.read_bucket(2, 2));
ASSERT_EQ(1UL, h.read_bucket(2, 2));
ASSERT_EQ(0, h.read_bucket(3, 3));
ASSERT_EQ(0UL, h.read_bucket(3, 3));
h.inc(2, 2);
ASSERT_EQ(1, h.read_bucket(3, 3));
ASSERT_EQ(1UL, h.read_bucket(3, 3));
ASSERT_EQ(0, h.read_bucket(4, 3));
ASSERT_EQ(0UL, h.read_bucket(4, 3));
h.inc(3, 3);
ASSERT_EQ(1, h.read_bucket(4, 3));
ASSERT_EQ(1UL, h.read_bucket(4, 3));
}
TEST(PerfHistogram, OneBucketRange) {
@ -123,7 +123,7 @@ TEST(PerfHistogram, OneBucketRange) {
PerfHistogramCommon::axis_config_d{"", PerfHistogramCommon::SCALE_LINEAR,
0, 1, 1});
ASSERT_EQ(1, ranges.size());
ASSERT_EQ(1UL, ranges.size());
ASSERT_EQ(std::numeric_limits<int64_t>::min(), ranges[0].first);
ASSERT_EQ(std::numeric_limits<int64_t>::max(), ranges[0].second);
}
@ -133,7 +133,7 @@ TEST(PerfHistogram, TwoBucketRange) {
PerfHistogramCommon::axis_config_d{"", PerfHistogramCommon::SCALE_LINEAR,
0, 1, 2});
ASSERT_EQ(2, ranges.size());
ASSERT_EQ(2UL, ranges.size());
ASSERT_EQ(std::numeric_limits<int64_t>::min(), ranges[0].first);
ASSERT_EQ(-1, ranges[0].second);
ASSERT_EQ(0, ranges[1].first);
@ -147,9 +147,9 @@ TEST(PerfHistogram, LinearBucketRange) {
for (size_t i = 0; i < ranges.size(); ++i) {
ASSERT_EQ(
i, PerfHistogramAccessor<1>::get_bucket_for_axis(ranges[i].first, ac));
static_cast<long>(i), PerfHistogramAccessor<1>::get_bucket_for_axis(ranges[i].first, ac));
ASSERT_EQ(
i, PerfHistogramAccessor<1>::get_bucket_for_axis(ranges[i].second, ac));
static_cast<long>(i), PerfHistogramAccessor<1>::get_bucket_for_axis(ranges[i].second, ac));
}
for (size_t i = 1; i < ranges.size(); ++i) {
@ -164,9 +164,9 @@ TEST(PerfHistogram, LogarithmicBucketRange) {
for (size_t i = 0; i < ranges.size(); ++i) {
ASSERT_EQ(
i, PerfHistogramAccessor<1>::get_bucket_for_axis(ranges[i].first, ac));
static_cast<long>(i), PerfHistogramAccessor<1>::get_bucket_for_axis(ranges[i].first, ac));
ASSERT_EQ(
i, PerfHistogramAccessor<1>::get_bucket_for_axis(ranges[i].second, ac));
static_cast<long>(i), PerfHistogramAccessor<1>::get_bucket_for_axis(ranges[i].second, ac));
}
for (size_t i = 1; i < ranges.size(); ++i) {