RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-23 11:07:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

qa/vstart_runner: add a helper method to run commands

Browse Source 
It's more convenient to not to pass stdout, stdin, and stderr every
single time.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
This commit is contained in:
Rishabh Dave 2021-09-29 15:10:12 +05:30
parent f12536fed1
commit acc923c8a4
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
qa/tasks/vstart_runner.py
View File

@ -129,6 +129,13 @@ def respawn_in_path(lib_path, python_paths):
sys.path.insert(0, p)
def launch_subprocess(args, cwd=None, env=None, shell=True,
executable='/bin/bash'):
return subprocess.Popen(args, cwd=cwd, env=env, shell=shell,
executable=executable, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, stdin=subprocess.PIPE)
# Let's use some sensible defaults
if os.path.exists("./CMakeCache.txt") and os.path.exists("./bin"):
@ -461,10 +468,7 @@ sudo() {
args, usr_args = self._perform_checks_and_adjustments(args, omit_sudo,
shell)
subproc = subprocess.Popen(args, stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
stdin=subprocess.PIPE, cwd=cwd, env=env,
shell=shell, executable='/bin/bash')
subproc = launch_subprocess(args, cwd, env, shell)
if stdin:
# Hack: writing to stdin is not deadlock-safe, but it "always" works