RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-02 00:52:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

compressor: use generate_random_number for type="random"

Browse Source 
use an existing thread-local random engine instead of constructing,
seeding, and locking a separate engine

Signed-off-by: Casey Bodley <cbodley@redhat.com>
This commit is contained in:
Casey Bodley 2017-10-12 12:46:09 -04:00
parent 651baae2da
commit acc6960040
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/compressor/Compressor.cc
View File

@ -17,6 +17,7 @@
#include "CompressionPlugin.h"
#include "Compressor.h"
#include "include/random.h"
#include "common/ceph_context.h"
#include "common/debug.h"
#include "common/dout.h"
@ -76,16 +77,7 @@ CompressorRef Compressor::create(CephContext *cct, const std::string &type)
{
// support "random" for teuthology testing
if (type == "random") {
static std::random_device seed;
static std::default_random_engine engine(seed());
static ceph::spinlock mutex;
int alg = COMP_ALG_NONE;
std::uniform_int_distribution<> dist(0, COMP_ALG_LAST - 1);
{
std::lock_guard<decltype(mutex)> lock(mutex);
alg = dist(engine);
}
int alg = ceph::util::generate_random_number(0, COMP_ALG_LAST - 1);
if (alg == COMP_ALG_NONE) {
return nullptr;
}