RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-24 19:47:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

osdc/Objecter: use list::push_back(T&&) for less memcpy

Browse Source 
also use range-based loop for better readablity.

Signed-off-by: Kefu Chai <kchai@redhat.com>
This commit is contained in:
Kefu Chai 2019-04-01 11:49:57 +08:00
parent f35fa1c58c
commit a9b7822d1b
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/osdc/Objecter.h
View File

@ -534,15 +534,15 @@ struct ObjectOperation {
obj_list_watch_response_t resp;
decode(resp, p);
if (pwatchers) {
for (auto i = resp.entries.begin(); i != resp.entries.end(); ++i) {
for (const auto& watch_item : resp.entries) {
obj_watch_t ow;
std::string sa = i->addr.get_legacy_str();
std::string sa = watch_item.addr.get_legacy_str();
strncpy(ow.addr, sa.c_str(), sizeof(ow.addr) - 1);
ow.addr[sizeof(ow.addr) - 1] = '\0';
ow.watcher_id = i->name.num();
ow.cookie = i->cookie;
ow.timeout_seconds = i->timeout_seconds;
pwatchers->push_back(ow);
ow.watcher_id = watch_item.name.num();
ow.cookie = watch_item.cookie;
ow.timeout_seconds = watch_item.timeout_seconds;
pwatchers->push_back(std::move(ow));
}
}
}