From 0227ab7570c41383bf2e87eb98077f9bb0effdbc Mon Sep 17 00:00:00 2001 From: John Spray Date: Fri, 21 Apr 2017 06:42:29 -0400 Subject: [PATCH] mon: don't call propose_pending in dispatch This was happening indirectly because the command handling code was calling tick() as a shortcut to "promote something" and tick calls propose_pending because. Fixes: http://tracker.ceph.com/issues/19738 Signed-off-by: John Spray --- src/mon/MgrMonitor.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mon/MgrMonitor.cc b/src/mon/MgrMonitor.cc index 29fd9a66f16..c00e7809d53 100644 --- a/src/mon/MgrMonitor.cc +++ b/src/mon/MgrMonitor.cc @@ -510,8 +510,8 @@ bool MgrMonitor::prepare_command(MonOpRequestRef op) } } - if (changed) { - tick(); + if (changed && pending_map.active_gid == 0) { + promote_standby(); } } else { r = -ENOSYS;