From a8e10d3d0a27436c6f1df2601678a8abcc4b79f5 Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Tue, 5 Nov 2013 19:40:47 +0100 Subject: [PATCH] os/ObjectStore.cc: prefer prefix ++operator for non-primitive types Prefer prefix ++operator for non-primitive types like iterators for performance reasons. Prefix ++/-- operators avoid creating a temporary copy. Signed-off-by: Danny Al-Gaaf --- src/os/ObjectStore.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/os/ObjectStore.cc b/src/os/ObjectStore.cc index 1a1bbcb0b67..327c64167d5 100644 --- a/src/os/ObjectStore.cc +++ b/src/os/ObjectStore.cc @@ -504,7 +504,7 @@ int ObjectStore::collection_list(coll_t c, vector& o) int ret = collection_list(c, go); if (ret == 0) { o.reserve(go.size()); - for (vector::iterator i = go.begin(); i != go.end() ; i++) + for (vector::iterator i = go.begin(); i != go.end() ; ++i) o.push_back(i->hobj); } return ret; @@ -520,7 +520,7 @@ int ObjectStore::collection_list_partial(coll_t c, hobject_t start, if (ret == 0) { *next = gnext.hobj; ls->reserve(go.size()); - for (vector::iterator i = go.begin(); i != go.end() ; i++) + for (vector::iterator i = go.begin(); i != go.end() ; ++i) ls->push_back(i->hobj); } return ret; @@ -534,7 +534,7 @@ int ObjectStore::collection_list_range(coll_t c, hobject_t start, hobject_t end, int ret = collection_list_range(c, gstart, gend, seq, &go); if (ret == 0) { ls->reserve(go.size()); - for (vector::iterator i = go.begin(); i != go.end() ; i++) + for (vector::iterator i = go.begin(); i != go.end() ; ++i) ls->push_back(i->hobj); } return ret;