RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-03-25 11:48:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12705 from badone/wip-ceph_test_rados_api_tier-valgrind-fixes

Browse Source 
test/librados/tier.cc: Fix valgrind errors

Reviewed-by: Sage Weil <sage@redhat.com>
This commit is contained in:
Kefu Chai 2017-01-04 18:08:46 +08:00 committed by GitHub
commit a7b78620f0
1 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/test/librados/tier.cc
View File

@ -114,6 +114,28 @@ protected:
librados::IoCtx cache_ioctx;
};
class Completions
{
public:
Completions() = default;
librados::AioCompletion* getCompletion() {
librados::AioCompletion* comp = librados::Rados::aio_create_completion();
m_completions.push_back(comp);
return comp;
}
~Completions() {
for (auto& comp : m_completions) {
comp->release();
}
}
private:
vector<librados::AioCompletion *> m_completions;
};
Completions completions;
std::string LibRadosTwoPoolsPP::cache_pool_name;
TEST_F(LibRadosTierPP, Dirty) {
@ -2022,8 +2044,7 @@ void start_flush_read()
//cout << " starting read" << std::endl;
ObjectReadOperation op;
op.stat(NULL, NULL, NULL);
librados::AioCompletion *completion =
librados::Rados::aio_create_completion();
librados::AioCompletion *completion = completions.getCompletion();
completion->set_complete_callback(0, flush_read_race_cb);
read_ioctx->aio_operate("foo", completion, &op, NULL);
}
@ -2038,7 +2059,6 @@ void flush_read_race_cb(completion_t cb, void *arg)
} else {
start_flush_read();
}
// fixme: i'm leaking cb...
test_lock.Unlock();
}