Merge PR #32755 into master

* refs/pull/32755/head:
	pybind/mgr/*: fix config_notify handling of default values

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
This commit is contained in:
Sage Weil 2020-01-24 14:02:14 -06:00
commit 9033c5e5bf
8 changed files with 8 additions and 8 deletions

View File

@ -106,7 +106,7 @@ class Alerts(MgrModule):
for opt in self.MODULE_OPTIONS:
setattr(self,
opt['name'],
self.get_module_option(opt['name']) or opt['default'])
self.get_module_option(opt['name']))
self.log.debug(' mgr option %s = %s',
opt['name'], getattr(self, opt['name']))
# Do the same for the native options.

View File

@ -678,7 +678,7 @@ class CephadmOrchestrator(MgrModule, orchestrator.OrchestratorClientMixin):
for opt in self.MODULE_OPTIONS:
setattr(self,
opt['name'], # type: ignore
self.get_module_option(opt['name']) or opt['default']) # type: ignore
self.get_module_option(opt['name'])) # type: ignore
self.log.debug(' mgr option %s = %s',
opt['name'], getattr(self, opt['name'])) # type: ignore
for opt in self.NATIVE_OPTIONS:

View File

@ -56,7 +56,7 @@ class Module(MgrModule):
for opt in self.MODULE_OPTIONS:
setattr(self,
opt['name'],
self.get_module_option(opt['name']) or opt['default'])
self.get_module_option(opt['name']))
self.log.debug(' mgr option %s = %s',
opt['name'], getattr(self, opt['name']))

View File

@ -142,7 +142,7 @@ class Module(MgrModule):
for opt in self.MODULE_OPTIONS:
setattr(self,
opt['name'],
self.get_module_option(opt['name']) or opt['default'])
self.get_module_option(opt['name']))
self.log.debug(' %s = %s', opt['name'], getattr(self, opt['name']))
if not self._activated_cloud and self.get_ceph_option('device_failure_prediction_mode') == 'cloud':
self._event.set()

View File

@ -54,7 +54,7 @@ class Module(MgrModule):
for opt in self.MODULE_OPTIONS:
setattr(self,
opt['name'],
self.get_module_option(opt['name']) or opt['default'])
self.get_module_option(opt['name']))
self.log.debug(' %s = %s', opt['name'], getattr(self, opt['name']))
if self.get_ceph_option('device_failure_prediction_mode') == 'local':
self._event.set()

View File

@ -83,7 +83,7 @@ class Hello(MgrModule):
for opt in self.MODULE_OPTIONS:
setattr(self,
opt['name'],
self.get_module_option(opt['name']) or opt['default'])
self.get_module_option(opt['name']))
self.log.debug(' mgr option %s = %s',
opt['name'], getattr(self, opt['name']))
# Do the same for the native options.

View File

@ -1079,7 +1079,7 @@ class Module(MgrModule):
for opt in self.MODULE_OPTIONS:
setattr(self,
opt['name'],
self.get_module_option(opt['name']) or opt['default'])
self.get_module_option(opt['name']))
if not self.kubernetes_control:
# Populate the config

View File

@ -97,7 +97,7 @@ class PgAutoscaler(MgrModule):
for opt in self.MODULE_OPTIONS:
setattr(self,
opt['name'],
self.get_module_option(opt['name']) or opt['default'])
self.get_module_option(opt['name']))
self.log.debug(' mgr option %s = %s',
opt['name'], getattr(self, opt['name']))