RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-24 03:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

crimson/os/seastore/transaction_manager: only add pin if not already pending

Browse Source 
If it's already pending, cache.duplicate_for_write is a noop and the extent
will already have a pin.  Also, add some debugging.

Signed-off-by: Samuel Just <sjust@redhat.com>
This commit is contained in:
Samuel Just 2020-08-20 12:38:20 -07:00
parent 31d3057a35
commit 9016932fef
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/crimson/os/seastore/transaction_manager.h
View File

@ -136,10 +136,25 @@ public:
/// Obtain mutable copy of extent
LogicalCachedExtentRef get_mutable_extent(Transaction &t, LogicalCachedExtentRef ref) {
auto &logger = crimson::get_logger(ceph_subsys_filestore);
auto ret = cache.duplicate_for_write(
t,
ref)->cast<LogicalCachedExtent>();
ret->set_pin(ref->get_pin().duplicate());
if (!ret->has_pin()) {
logger.debug(
"{}: duplicating {} for write: {}",
__func__,
*ref,
*ret);
ret->set_pin(ref->get_pin().duplicate());
} else {
logger.debug(
"{}: {} already pending",
__func__,
*ref);
assert(ref->is_pending());
assert(&*ref == &*ret);
}
return ret;
}