RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-03 01:22:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

SubmittingPatches: clarify how Reviewed-by lines are added

Browse Source 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
This commit is contained in:
Nathan Cutler 2015-06-06 15:16:16 +02:00
parent eefdeb6b79
commit 85b327f85a
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
SubmittingPatches
View File

@ -273,6 +273,15 @@ A: The target branch depends on the nature of your change:
you are fixing a bug that exists on the "firefly" branch and that you
desire that your change be cherry-picked to that branch.
Q: How to include Reviewed-by: tag(s) in my pull request?
You don't. If someone reviews your pull request, they should indicate they
have done so by commenting on it with "+1", "looks good to me", "LGTM",
and/or the entire "Reviewed-by: ..." line with their name and email address.
The developer merging the pull request should note positive reviews and
include the appropriate Reviewed-by: lines in the merge commit.
2) Patch submission via ceph-devel@vger.kernel.org
The best way to generate a patch for manual submission is to work from