From 764ce71bd202315fdf4403d9e1e8ae55ef849a90 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Wed, 25 Mar 2020 10:39:59 -0500 Subject: [PATCH] mgr/cephadm: fix 'orch ps --refresh' The use of host in the refresh loop was clobbering the argument value. Fixes: https://tracker.ceph.com/issues/44513 Signed-off-by: Sage Weil --- src/pybind/mgr/cephadm/module.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py index 38f369c121c..1e8ee4e8fd9 100644 --- a/src/pybind/mgr/cephadm/module.py +++ b/src/pybind/mgr/cephadm/module.py @@ -1915,8 +1915,8 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule): if host: self._refresh_host_daemons(host) else: - for host, hi in self.inventory.items(): - self._refresh_host_daemons(host) + for hostname, hi in self.inventory.items(): + self._refresh_host_daemons(hostname) result = [] for h, dm in self.cache.daemons.items(): if host and h != host: