RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-20 01:51:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

cephtool: fix resource leak

Browse Source 
CID 717124: Resource leak (RESOURCE_LEAK)
At (17): Variable "m" going out of scope leaks the storage it points to.

Signed-off-by: Sage Weil <sage@inktank.com>
This commit is contained in:
Sage Weil 2012-09-28 08:09:09 -07:00
parent 779e0f0fb0
commit 70e35ba9b1
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/tools/common.cc
View File

@ -134,11 +134,6 @@ static void send_command(CephToolCtx *ctx)
if (!ctx->concise)
*ctx->log << ceph_clock_now(g_ceph_context) << " " << pending_target << " <- " << pending_cmd << std::endl;
MCommand *m = new MCommand(ctx->mc.monmap.fsid);
m->cmd = pending_cmd;
m->set_data(pending_bl);
m->set_tid(++pending_tid);
if (pending_tell_pgid) {
// pick target osd
vector<int> osds;
@ -172,10 +167,14 @@ static void send_command(CephToolCtx *ctx)
reply_rc = -ESRCH;
reply = true;
} else {
if (!ctx->concise)
*ctx->log << ceph_clock_now(g_ceph_context) << " " << pending_target << " <- " << pending_cmd << std::endl;
MCommand *m = new MCommand(ctx->mc.monmap.fsid);
m->cmd = pending_cmd;
m->set_data(pending_bl);
m->set_tid(++pending_tid);
command_con = messenger->get_connection(osdmap->get_inst(n));
messenger->send_message(m, command_con);