RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-20 10:01:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

common/cmdparse: no need to use (and leak to) the heap

Browse Source 
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
This commit is contained in:
Sage Weil 2013-06-10 17:11:44 -07:00
parent 5c945cd1b8
commit 6bab425342
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/common/cmdparse.cc
View File

@ -138,14 +138,14 @@ cmdmap_from_json(vector<string> cmd, map<string, cmd_vartype> *mapp, stringstrea
// array is a vector of values. Unpack it to a vector // array is a vector of values. Unpack it to a vector
// of strings, the only type we handle. // of strings, the only type we handle.
vector<json_spirit::mValue> spvals = it->second.get_array(); vector<json_spirit::mValue> spvals = it->second.get_array();
vector<string> *outvp = new vector<string>; vector<string> outv;
for (vector<json_spirit::mValue>::iterator sv = spvals.begin(); for (vector<json_spirit::mValue>::iterator sv = spvals.begin();
sv != spvals.end(); sv++) { sv != spvals.end(); sv++) {
if (sv->type() != json_spirit::str_type) if (sv->type() != json_spirit::str_type)
throw(runtime_error("Can't handle arrays of non-strings")); throw(runtime_error("Can't handle arrays of non-strings"));
outvp->push_back(sv->get_str()); outv.push_back(sv->get_str());
} }
(*mapp)[it->first] = *outvp; (*mapp)[it->first] = outv;
} }
break; break;
case json_spirit::str_type: case json_spirit::str_type: