RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-21 02:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

mgr: ignore modules that fail to instantiate

Browse Source 
If an uncaught runtime exception occurs in a module constructor, then
the manager still tries to deliver notifications resulting in errors
like:

src/mgr/ActivePyModule.cc: 54: FAILED assert(pClassInstance != nullptr)

This removes the failed module from the set of active modules that
should receive command and notifications.

This also serves as a basis for accurately determining if the manager
satisifes all "always on" module constraints.

Signed-off-by: Noah Watkins <nwatkins@redhat.com>
This commit is contained in:
Noah Watkins 2018-07-15 13:02:58 -07:00
parent a4ec7f5f22
commit 6a8b5d8425
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mgr/ActivePyModules.cc
View File

@ -386,6 +386,9 @@ int ActivePyModules::start_one(PyModuleRef py_module)
int r = active_module->load(this);
if (r != 0) {
// the class instance wasn't created... remove it from the set of activated
// modules so commands and notifications aren't delivered.
modules.erase(py_module->get_name());
return r;
} else {
dout(4) << "Starting thread for " << py_module->get_name() << dendl;