From 6336f72244d26c4d92c62770eb8d54c5ccc6d337 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 6 Oct 2020 19:03:38 +0800 Subject: [PATCH] crimson/os: mark dtor of interface class "virtual" we use a smart_ptr in Seastore to manage the life cycle of `TransactionManager` which is in turn a subclass `ExtentCallbackInterface`, so should declare the dtor of latter as virtual. Signed-off-by: Kefu Chai --- src/crimson/os/seastore/segment_cleaner.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/crimson/os/seastore/segment_cleaner.h b/src/crimson/os/seastore/segment_cleaner.h index c4943a1590f..43a2897ca05 100644 --- a/src/crimson/os/seastore/segment_cleaner.h +++ b/src/crimson/os/seastore/segment_cleaner.h @@ -37,6 +37,7 @@ public: /// Callback interface for querying and operating on segments class ExtentCallbackInterface { public: + virtual ~ExtentCallbackInterface() = default; /** * get_next_dirty_extent *