RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-24 03:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

crimson/os/seastore/lba_manager: drop from cache directly during replay if dead

Browse Source 
Dead extents can't go through the normal retire_extent path as they don't
have valid pins or other elements of a real extent.  Instead, simply drop
them on the floor directly.

Signed-off-by: Samuel Just <sjust@redhat.com>
This commit is contained in:
Samuel Just 2020-08-20 14:23:14 -07:00
parent 5539b54547
commit 5e840a20b8
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/crimson/os/seastore/cache.h
View File

@ -85,6 +85,17 @@ public:
Cache(SegmentManager &segment_manager);
~Cache();
/**
* drop_from_cache
*
* Drop extent from cache. Intended for use when
* ref refers to a logically dead extent as during
* replay.
*/
void drop_from_cache(CachedExtentRef ref) {
remove_extent(ref);
}
/// Declare ref retired in t
void retire_extent(Transaction &t, CachedExtentRef ref) {
t.add_to_retired_set(ref);

6
src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc
View File

@ -259,7 +259,7 @@ BtreeLBAManager::init_cached_extent_ret BtreeLBAManager::init_cached_extent(
} else {
// e is obsolete
logger().debug("init_cached_extent: {} obsolete", *e);
cache.retire_extent(t, e);
cache.drop_from_cache(e);
}
return init_cached_extent_ertr::now();
});
@ -279,12 +279,12 @@ BtreeLBAManager::init_cached_extent_ret BtreeLBAManager::init_cached_extent(
} else {
// paddr doesn't match, remapped, obsolete
logger().debug("init_cached_extent: {} obsolete", *logn);
cache.retire_extent(t, logn);
cache.drop_from_cache(logn);
}
} else {
// set of extents changed, obsolete
logger().debug("init_cached_extent: {} obsolete", *logn);
cache.retire_extent(t, logn);
cache.drop_from_cache(logn);
}
return init_cached_extent_ertr::now();
});