RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-17 16:07:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmake: Fix unaligned check on big-endian systems

Browse Source 
On big-endian systems, ntohl is a no-op, so "good" never does
any conversion.  Fix this by keeping the test constants in
big-endian (network) order and using ntohl to convert them
to native (host) byte order.

Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
This commit is contained in:
Ulrich Weigand 2019-09-12 15:46:06 +02:00
parent 193ef136a3
commit 5a189bdd41
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
cmake/modules/CephChecks.cmake
View File

@ -104,23 +104,18 @@ uint32_t load(char* p, size_t offset)
return *reinterpret_cast<uint32_t*>(p + offset);
}
bool good(uint32_t lhs, uint32_t small_endian)
bool good(uint32_t lhs, uint32_t big_endian)
{
uint32_t rhs;
if (ntohl(0xdeadbeaf) == 0xdeadbeaf) {
return lhs == ntohl(small_endian);
} else {
return lhs == small_endian;
}
return lhs == ntohl(big_endian);
}
int main(int argc, char **argv)
{
char a1[] = \"ABCDEFG\";
uint32_t a2[] = {0x44434241,
0x45444342,
0x46454443,
0x47464544};
uint32_t a2[] = {0x41424344,
0x42434445,
0x43444546,
0x44454647};
for (size_t i = 0; i < std::size(a2); i++) {
if (!good(load(a1, i), a2[i])) {
return 1;