RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-03-25 11:48:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

obj_bencher: protect with lock

Browse Source 
This makes coverity happy.

CID 716963: Data race condition (MISSING_LOCK)
At (1): Accessing "this->data.finished" ("bench_data.finished") requires the "Mutex._m" lock.

Signed-off-by: Sage Weil <sage@inktank.com>
This commit is contained in:
Sage Weil 2012-09-27 20:55:37 -07:00
parent f577c8291f
commit 5846e27b73
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/common/obj_bencher.cc
View File

@ -490,8 +490,6 @@ int ObjBencher::write_bench(int secondsToRun, int concurrentios) {
}
int ObjBencher::seq_read_bench(int seconds_to_run, int num_objects, int concurrentios, int pid) {
data.finished = 0;
lock_cond lc(&lock);
std::string name[concurrentios];
std::string newName;
@ -518,12 +516,14 @@ int ObjBencher::seq_read_bench(int seconds_to_run, int num_objects, int concurre
contents[i] = new bufferlist();
}
lock.Lock();
data.finished = 0;
data.start_time = ceph_clock_now(g_ceph_context);
lock.Unlock();
pthread_t print_thread;
pthread_create(&print_thread, NULL, status_printer, (void *)this);
lock.Lock();
data.start_time = ceph_clock_now(g_ceph_context);
lock.Unlock();
utime_t finish_time = data.start_time + time_to_run;
//start initial reads
for (int i = 0; i < concurrentios; ++i) {