RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-20 10:01:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

suite: make email-on-success the default behavior

Browse Source 
This way you can tell when a run is complete, instead of wondering if
it's stuck in the queue.
This commit is contained in:
Josh Durgin 2012-01-05 17:27:28 -08:00
parent ec3a3a9654
commit 561f06cf94
3 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
teuthology/queue.py
View File

@ -90,8 +90,6 @@ describe. One job is run at a time.
'--name',
job_config['name'],
]
if job_config.get('email_on_success', False):
args.append('--email-on-success')
subprocess.Popen(args=args)
else:
log.debug('Creating archive dir...')

8
teuthology/run.py
View File

@ -208,12 +208,6 @@ def schedule():
'--email',
help='where to send the results of a suite (only applies to the last job in a suite)',
)
parser.add_argument(
'--email-on-success',
action='store_true',
default=False,
help='email even if all tests pass',
)
parser.add_argument(
'--timeout',
help='how many seconds to wait for jobs to finish before emailing results (only applies to the last job in a suite',
@ -245,7 +239,6 @@ def schedule():
if not ctx.last_in_suite:
assert not ctx.email, '--email is only applicable to the last job in a suite'
assert not ctx.timeout, '--timeout is only applicable to the last job in a suite'
assert not ctx.email_on_success, '--email-on-success is only applicable to the last job in a suite'
from teuthology.misc import read_config, get_user
if ctx.owner is None:
@ -271,7 +264,6 @@ def schedule():
name=ctx.name,
last_in_suite=ctx.last_in_suite,
email=ctx.email,
email_on_success=ctx.email_on_success,
description=ctx.description,
owner=ctx.owner,
verbose=ctx.verbose,

14
teuthology/suite.py
View File

@ -55,12 +55,6 @@ combination, and will override anything in the suite.
'--email',
help='address to email test failures to',
)
parser.add_argument(
'--email-on-success',
action='store_true',
default=False,
help='email even if all tests pass',
)
parser.add_argument(
'--timeout',
help='how many seconds to wait for jobs to finish before emailing results',
@ -194,12 +188,6 @@ def results():
'--email',
help='address to email test failures to',
)
parser.add_argument(
'--email-on-success',
action='store_true',
default=False,
help='email even if all tests pass',
)
parser.add_argument(
'--timeout',
help='how many seconds to wait for all tests to finish (default no wait)',
@ -299,7 +287,7 @@ def results():
reason=summary['failure_reason'],
))
if not args.email or not (failures or unfinished or args.email_on_success):
if not args.email:
return
if failures or unfinished: