RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-24 03:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #33573 from votdev/fix_mypy_issue

Browse Source 
mgr/dashboard: make check mypy failure

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
This commit is contained in:
Laura Paduano 2020-02-27 11:30:06 +01:00 committed by GitHub
commit 53febd478d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/pybind/mgr/dashboard/services/ceph_service.py
View File

@ -166,6 +166,7 @@ class CephService(object):
@staticmethod
def _get_smart_data_by_device(device):
# type: (dict) -> Dict[str, dict]
# Check whether the device is associated with daemons.
if 'daemons' in device and device['daemons']:
dev_smart_data = None
@ -187,7 +188,7 @@ class CephService(object):
# that are 'up'. All daemons on the same host can deliver
# SMART data, thus it is not relevant for us which daemon
# we are using.
daemons = list(set(daemons) & set(osd_daemons_up))
daemons = list(set(daemons) & set(osd_daemons_up)) # type: ignore
for daemon in daemons:
svc_type, svc_id = daemon.split('.')
@ -249,7 +250,7 @@ class CephService(object):
@staticmethod
def get_smart_data_by_daemon(daemon_type, daemon_id):
# type: (str, str) -> dict
# type: (str, str) -> Dict[str, dict]
"""
Get the SMART data of the devices associated with the given daemon.
:param daemon_type: The daemon type, e.g. 'osd' or 'mon'.
@ -259,7 +260,7 @@ class CephService(object):
key in the dictionary.
"""
devices = CephService.get_devices_by_daemon(daemon_type, daemon_id)
smart_data = {}
smart_data = {} # type: Dict[str, dict]
if devices:
for device in devices:
if device['devid'] not in smart_data: