RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-23 19:17:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

mon: Monitor: fix potential null-pointer dereference

Browse Source 
CID 717443: Dereference after null check (FORWARD_NULL)
At (14): Passing null pointer "detailbl" to function
"ceph::buffer::list::append(std::string const &)", which dereferences it.


Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
This commit is contained in:
Joao Eduardo Luis 2012-10-17 15:23:11 +01:00
parent 64bf7f9b28
commit 52dedc8986
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mon/Monitor.cc
View File

@ -1324,8 +1324,10 @@ void Monitor::get_health(string& status, bufferlist *detailbl, Formatter *f)
while (!detail.empty()) {
if (f)
f->dump_string("item", detail.front().second);
detailbl->append(detail.front().second);
detailbl->append('\n');
if (detailbl != NULL) {
detailbl->append(detail.front().second);
detailbl->append('\n');
}
detail.pop_front();
}
if (f)