RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-23 19:17:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

mgr/cephadm: fix =[] default arg to _create_daemon

Browse Source 
This is a no-no (pass by reference, not value)!

Signed-off-by: Sage Weil <sage@redhat.com>
This commit is contained in:
Sage Weil 2019-12-23 10:29:52 -06:00
parent 2ae3f66263
commit 50d247f5a2
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pybind/mgr/cephadm/module.py
View File

@ -1044,8 +1044,10 @@ class CephadmOrchestrator(MgrModule, orchestrator.Orchestrator):
return self._remove_daemon(args)
def _create_daemon(self, daemon_type, daemon_id, host, keyring,
extra_args=[], extra_config=None,
extra_args=None, extra_config=None,
reconfig=False):
if not extra_args:
extra_args = []
name = '%s.%s' % (daemon_type, daemon_id)
# generate config