RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-21 01:47:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

PG: drop messages from down peers

Browse Source 
This overlaps with the existing old_peering_msg() mechanism
except in one case: pulls from a replica not in the acting
set.  If such a replica gets marked down, we may resend
pulls to another replica without causing a new interval
to start.  If we recieved, but didn't process, a push in
response to such a pull prior to processing the map marking
the peer down, we might process the push after having reset
the pull state for a different pull operation.  We can
avoid this by discarding ops from down peers.

Signed-off-by: Samuel Just <sam.just@inktank.com>
This commit is contained in:
Samuel Just 2014-01-19 01:17:49 -08:00
parent e73a9f7b7a
commit 4fc4573fd2
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/osd/PG.cc
View File

@ -4868,6 +4868,15 @@ bool PG::can_discard_replica_op(OpRequestRef op)
T *m = static_cast<T *>(op->get_req()); T *m = static_cast<T *>(op->get_req());
assert(m->get_header().type == MSGTYPE); assert(m->get_header().type == MSGTYPE);
/* Mostly, this overlaps with the old_peering_msg
* condition. An important exception is pushes
* sent by replicas not in the acting set, since
* if such a replica goes down it does not cause
* a new interval. */
int from = m->get_source().num();
if (get_osdmap()->get_down_at(from) >= m->map_epoch)
return true;
// same pg? // same pg?
// if pg changes _at all_, we reset and repeer! // if pg changes _at all_, we reset and repeer!
if (old_peering_msg(m->map_epoch, m->map_epoch)) { if (old_peering_msg(m->map_epoch, m->map_epoch)) {