From 3081652119ca9614623fcd21bdcf299f2102ed9b Mon Sep 17 00:00:00 2001
From: Loic Dachary <loic@dachary.org>
Date: Sat, 24 May 2014 12:52:30 +0200
Subject: [PATCH 1/2] os: ObjectStore::collect_metadata unit tests

And an emacs-executable reminder about how to run a specific test.

Signed-off-by: Loic Dachary <loic@dachary.org>
---
 src/test/objectstore/store_test.cc | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/src/test/objectstore/store_test.cc b/src/test/objectstore/store_test.cc
index ca9683b9385..76c1141b4b1 100644
--- a/src/test/objectstore/store_test.cc
+++ b/src/test/objectstore/store_test.cc
@@ -75,6 +75,15 @@ bool sorted(const vector<ghobject_t> &in) {
   return true;
 }
 
+TEST_P(StoreTest, collect_metadata) {
+  map<string,string> pm;
+  store->collect_metadata(&pm);
+  if (GetParam() == string("filestore")) {
+    ASSERT_NE(pm.count("filestore_backend"), 0);
+    ASSERT_NE(pm.count("filestore_f_type"), 0);
+  }
+}
+
 TEST_P(StoreTest, SimpleColTest) {
   coll_t cid = coll_t("initial");
   int r = 0;
@@ -1265,6 +1274,11 @@ int main(int argc, char **argv) {
   return RUN_ALL_TESTS();
 }
 
-// Local Variables:
-// compile-command: "cd ../.. ; make ceph_test_objectstore ; ./ceph_test_objectstore --gtest_filter=StoreTest.* --log-to-stderr=true --debug-filestore=20"
-// End:
+/*
+ * Local Variables:
+ * compile-command: "cd ../.. ; make ceph_test_objectstore && 
+ *    ./ceph_test_objectstore \
+ *        --gtest_filter=*.collect_metadata* --log-to-stderr=true --debug-filestore=20
+ *  "
+ * End:
+ */

From 08b3cff59dca223dc5f86531139ab4abe5170105 Mon Sep 17 00:00:00 2001
From: Loic Dachary <loic@dachary.org>
Date: Sat, 24 May 2014 14:49:19 +0200
Subject: [PATCH 2/2] os: FileStore::create_backend unit tests

Assert that the fs_type is mapped to a backend that claims to have the
matching name.

Signed-off-by: Loic Dachary <loic@dachary.org>
---
 src/os/FileStore.h                  |  1 +
 src/test/Makefile.am                |  5 ++
 src/test/filestore/TestFileStore.cc | 87 +++++++++++++++++++++++++++++
 3 files changed, 93 insertions(+)
 create mode 100644 src/test/filestore/TestFileStore.cc

diff --git a/src/os/FileStore.h b/src/os/FileStore.h
index 4312400449f..941b8d240ae 100644
--- a/src/os/FileStore.h
+++ b/src/os/FileStore.h
@@ -637,6 +637,7 @@ private:
   int read_superblock();
 
   friend class FileStoreBackend;
+  friend class TestFileStore;
 };
 
 ostream& operator<<(ostream& out, const FileStore::OpSequencer& s);
diff --git a/src/test/Makefile.am b/src/test/Makefile.am
index e2fbf48e7ec..5b854919adf 100644
--- a/src/test/Makefile.am
+++ b/src/test/Makefile.am
@@ -789,6 +789,11 @@ ceph_test_objectstore_SOURCES = test/objectstore/store_test.cc
 ceph_test_objectstore_LDADD = $(LIBOS) $(UNITTEST_LDADD) $(CEPH_GLOBAL)
 ceph_test_objectstore_CXXFLAGS = $(UNITTEST_CXXFLAGS)
 bin_DEBUGPROGRAMS += ceph_test_objectstore
+
+ceph_test_filestore_SOURCES = test/filestore/TestFileStore.cc
+ceph_test_filestore_LDADD = $(LIBOS) $(UNITTEST_LDADD) $(CEPH_GLOBAL)
+ceph_test_filestore_CXXFLAGS = $(UNITTEST_CXXFLAGS)
+bin_DEBUGPROGRAMS += ceph_test_filestore
 endif
 
 ceph_test_objectstore_workloadgen_SOURCES = \
diff --git a/src/test/filestore/TestFileStore.cc b/src/test/filestore/TestFileStore.cc
new file mode 100644
index 00000000000..a9b58a1468f
--- /dev/null
+++ b/src/test/filestore/TestFileStore.cc
@@ -0,0 +1,87 @@
+// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
+// vim: ts=8 sw=2 smarttab
+/*
+ * Ceph - scalable distributed file system
+ *
+ * Copyright (C) 2014 Cloudwatt <libre.licensing@cloudwatt.com>
+ *
+ * Author: Loic Dachary <loic@dachary.org>
+ *
+ * This is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2.1, as published by the Free Software
+ * Foundation.  See file COPYING.
+ *
+ */
+
+#include "common/ceph_argparse.h"
+#include "global/global_init.h"
+#include "os/FileStore.h"
+#include <gtest/gtest.h>
+
+class TestFileStore {
+public:
+  static void create_backend(FileStore &fs, long f_type) {
+    fs.create_backend(f_type);
+  }
+};
+
+TEST(FileStore, create)
+{
+  {
+    map<string,string> pm;
+    FileStore fs("a", "b");
+    TestFileStore::create_backend(fs, 0);
+    fs.collect_metadata(&pm);
+    ASSERT_EQ(pm["filestore_backend"], "generic");
+  }
+#if defined(__linux__)
+  {
+    map<string,string> pm;
+    FileStore fs("a", "b");
+    TestFileStore::create_backend(fs, BTRFS_SUPER_MAGIC);
+    fs.collect_metadata(&pm);
+    ASSERT_EQ(pm["filestore_backend"], "btrfs");
+  }
+# ifdef HAVE_LIBXFS
+  {
+    map<string,string> pm;
+    FileStore fs("a", "b");
+    TestFileStore::create_backend(fs, XFS_SUPER_MAGIC);
+    fs.collect_metadata(&pm);
+    ASSERT_EQ(pm["filestore_backend"], "xfs");
+  }
+# endif
+#endif
+#ifdef HAVE_LIBZFS
+  {
+    map<string,string> pm;
+    FileStore fs("a", "b");
+    TestFileStore::create_backend(fs, ZFS_SUPER_MAGIC);
+    fs.collect_metadata(&pm);
+    ASSERT_EQ(pm["filestore_backend"], "zfs");
+  }
+#endif
+}
+
+int main(int argc, char **argv) {
+  vector<const char*> args;
+  argv_to_vec(argc, (const char **)argv, args);
+
+  global_init(NULL, args, CEPH_ENTITY_TYPE_CLIENT, CODE_ENVIRONMENT_UTILITY, 0);
+  common_init_finish(g_ceph_context);
+  g_ceph_context->_conf->set_val("osd_journal_size", "100");
+  g_ceph_context->_conf->apply_changes(NULL);
+
+  ::testing::InitGoogleTest(&argc, argv);
+  return RUN_ALL_TESTS();
+}
+
+/*
+ * Local Variables:
+ * compile-command: "cd ../.. ; make ceph_test_filestore && 
+ *    ./ceph_test_filestore \
+ *        --gtest_filter=*.* --log-to-stderr=true --debug-filestore=20
+ *  "
+ * End:
+ */