Merge PR #53734 into main

* refs/pull/53734/head:
	qa: refactor client upgrade yamls and other minor touchups
	qa/upgrade/nofs: upgrade pacific->reef
	qa/upgrade/upgraded_client: upgrade nautilus->pacific and pacific->reef

Reviewed-by: Venky Shankar <vshankar@redhat.com>

qa/suites/fs/upgrade/nofs/tasks/1-upgrade.yaml

@@ -23,6 +23,7 @@ tasks:
     - ceph fs dump
 - install.upgrade:
     mon.a:
+      branch: reef
 - print: "**** done install.upgrade"
 - ceph.restart:
     daemons: [mon.*, mgr.*]

qa/suites/fs/upgrade/upgraded_client/branch/nautilus.yaml

@@ -0,0 +1,2 @@
+teuthology:
+  branch: nautilus

qa/suites/fs/upgrade/upgraded_client/branch/pacific.yaml

@@ -0,0 +1,2 @@
+teuthology:
+  branch: pacific

qa/suites/fs/upgrade/upgraded_client/tasks/0-from/pacific.yaml

@@ -1,53 +0,0 @@
-meta:
-- desc: |
-   install ceph/pacific latest
-tasks:
-- install:
-    branch: pacific
-    exclude_packages:
-      - cephadm
-      - ceph-mgr-cephadm
-      - ceph-immutable-object-cache
-      - python3-rados
-      - python3-rgw
-      - python3-rbd
-      - python3-cephfs
-      - ceph-volume
-    extra_packages:
-      - python-rados
-      - python-rgw
-      - python-rbd
-      - python-cephfs
-    # For kernel_untar_build workunit
-    extra_system_packages:
-      - bison
-      - flex
-      - elfutils-libelf-devel
-      - openssl-devel
-      - NetworkManager
-      - iproute
-      - util-linux
-- print: "**** done installing pacific"
-- ceph:
-    log-ignorelist:
-      - overall HEALTH_
-      - \(FS_
-      - \(MDS_
-      - \(OSD_
-      - \(MON_DOWN\)
-      - \(CACHE_POOL_
-      - \(POOL_
-      - \(MGR_DOWN\)
-      - \(PG_
-      - \(SMALLER_PGP_NUM\)
-      - Monitor daemon marked osd
-      - Behind on trimming
-      - Manager daemon
-    conf:
-      global:
-        mon warn on pool no app: false
-        ms bind msgr2: false
-- exec:
-    osd.0:
-      - ceph osd set-require-min-compat-client pacific
-- print: "**** done ceph"

qa/suites/fs/upgrade/upgraded_client/tasks/0-install.yaml

@@ -1,9 +1,15 @@
-meta:
-- desc: |
-   install ceph/nautilus latest
+teuthology:
+  premerge: |
+            local branch = yaml.teuthology.branch
+            yaml_fragment['tasks'][0]['install']['branch'] = tostring(branch)
+            print_branch = "**** done installing "..tostring(branch)
+            yaml_fragment['tasks'][1]['print'] = print_branch
+            local exec = yaml_fragment['tasks'][3]['exec']['osd.0']
+            local set_compat = "ceph osd set-require-min-compat-client "..tostring(branch)
+            py_attrgetter(exec).append(set_compat)
 tasks:
 - install:
-    branch: nautilus
+    branch: []
     exclude_packages:
       - cephadm
       - ceph-mgr-cephadm
@@ -27,7 +33,7 @@ tasks:
       - NetworkManager
       - iproute
       - util-linux
-- print: "**** done installing nautilus"
+- print: []
 - ceph:
     log-ignorelist:
       - overall HEALTH_
@@ -48,6 +54,5 @@ tasks:
         mon warn on pool no app: false
         ms bind msgr2: false
 - exec:
-    osd.0:
-      - ceph osd set-require-min-compat-client nautilus
+    osd.0: []
 - print: "**** done ceph"

qa/suites/fs/upgrade/upgraded_client/tasks/2-clients/fuse-upgrade.yaml

@@ -0,0 +1,25 @@
+teuthology:
+  premerge: |
+            local branch = yaml.teuthology.branch
+            if tostring(branch) == "nautilus" then
+              yaml_fragment['tasks'][2]['install.upgrade']['client.0']['branch'] = "pacific"
+            elseif tostring(branch) == "pacific" then
+              yaml_fragment['tasks'][2]['install.upgrade']['client.0']['branch'] = "reef"
+            else
+              error("invalid source branch")
+            end
+  postmerge:
+    - if not is_fuse() then reject() end
+tasks:
+- ceph-fuse:
+    client.0:
+      mounted: false
+- print: "**** done unmount client.0"
+- install.upgrade:
+    client.0:
+      branch: []
+- print: "**** done install.upgrade on client.0"
+- ceph.healthy:
+- ceph-fuse:
+    client.0:
+- print: "**** done remount client.0"

qa/suites/fs/upgrade/upgraded_client/tasks/2-workload/new_ops/0-clients/fuse-upgrade.yaml

@@ -1,15 +0,0 @@
-teuthology:
-  postmerge:
-    - if not is_fuse() then reject() end
-tasks:
-- ceph-fuse:
-    client.0:
-      mounted: false
-- print: "**** done unmount client.0"
-- install.upgrade:
-    client.0:
-- print: "**** done install.upgrade on client.0"
-- ceph.healthy:
-- ceph-fuse:
-    client.0:
-- print: "**** done remount client"

qa/suites/fs/upgrade/upgraded_client/tasks/2-workload/stress_tests/0-client-upgrade.yaml

@@ -1,14 +0,0 @@
-teuthology:
-  postmerge:
-    - if not is_fuse() then reject() end
-tasks:
-- ceph-fuse:
-    client.0:
-      mounted: false
-- print: "**** done unmount client.0"
-- install.upgrade:
-    client.0:
-- print: "**** done install.upgrade on client.0"
-- ceph-fuse:
-    client.0:
-- print: "**** done remount client.0"

qa/suites/fs/upgrade/upgraded_client/tasks/2-workload/stress_tests/1-tests/.qa

@@ -1 +0,0 @@
-../.qa/