From d622dadef09a53d24c6a7b9119051594f8da1cae Mon Sep 17 00:00:00 2001 From: Andrew Schoen Date: Tue, 19 Jun 2018 14:34:57 -0500 Subject: [PATCH] lvm: when osd creation fails log the exception Fixes: http://tracker.ceph.com/issues/24456 Signed-off-by: Andrew Schoen --- src/ceph-volume/ceph_volume/devices/lvm/create.py | 2 +- src/ceph-volume/ceph_volume/devices/lvm/prepare.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ceph-volume/ceph_volume/devices/lvm/create.py b/src/ceph-volume/ceph_volume/devices/lvm/create.py index 4fdd6e7625f..338c8f40447 100644 --- a/src/ceph-volume/ceph_volume/devices/lvm/create.py +++ b/src/ceph-volume/ceph_volume/devices/lvm/create.py @@ -31,7 +31,7 @@ class Create(object): # activate, which would never need to be rolled back. Activate([]).activate(args) except Exception: - logger.error('lvm activate was unable to complete, while creating the OSD') + logger.exception('lvm activate was unable to complete, while creating the OSD') logger.info('will rollback OSD ID creation') rollback_osd(args, osd_id) raise diff --git a/src/ceph-volume/ceph_volume/devices/lvm/prepare.py b/src/ceph-volume/ceph_volume/devices/lvm/prepare.py index c8438ff8c96..824a7c95936 100644 --- a/src/ceph-volume/ceph_volume/devices/lvm/prepare.py +++ b/src/ceph-volume/ceph_volume/devices/lvm/prepare.py @@ -215,7 +215,7 @@ class Prepare(object): try: self.prepare(args) except Exception: - logger.error('lvm prepare was unable to complete') + logger.exception('lvm prepare was unable to complete') logger.info('will rollback OSD ID creation') rollback_osd(args, self.osd_id) raise