From 2dc3770f7a195f6575277ad2ccd7c1e2bc1abcdc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rados=C5=82aw=20Zarzy=C5=84ski?= Date: Sat, 2 Apr 2022 11:22:19 +0200 Subject: [PATCH] crimson/osd: document OperationThrottler's behavior towards op's blocker list. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Radosław Zarzyński --- src/crimson/osd/osd_operation.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/crimson/osd/osd_operation.h b/src/crimson/osd/osd_operation.h index d883af55b8f..1eee01554b2 100644 --- a/src/crimson/osd/osd_operation.h +++ b/src/crimson/osd/osd_operation.h @@ -183,6 +183,10 @@ class OperationThrottler : public BlockerT, F &&f) { if (!max_in_progress) return f(); auto fut = acquire_throttle(params); + // At any given moment a particular op can be blocked by a given + // OperationThrottler instance no more than once. This means the + // same throtter won't be on the op's blockers list more than one + // time. return op->with_blocking_future(std::move(fut)) .then(std::forward(f)) .then([this](auto x) {