RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-20 01:51:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

filestore: check lseek64 return value

Browse Source 
CID 716862: Other violation (CHECKED_RETURN)
At (3): Calling function "lseek64(to, dstoff, 0)" without checking return value. This library function may fail and return an error code.

Signed-off-by: Sage Weil <sage@inktank.com>
This commit is contained in:
Sage Weil 2012-09-30 20:50:16 -07:00
parent 409fbb7cbc
commit 2bf3f8c588
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/os/FileStore.cc
View File

@ -3429,8 +3429,20 @@ int FileStore::_do_copy_range(int from, int to, uint64_t srcoff, uint64_t len, u
{
dout(20) << "_do_copy_range " << srcoff << "~" << len << " to " << dstoff << dendl;
int r = 0;
::lseek64(from, srcoff, SEEK_SET);
::lseek64(to, dstoff, SEEK_SET);
int64_t actual;
actual = ::lseek64(from, srcoff, SEEK_SET);
if (actual != (int64_t)srcoff) {
r = errno;
derr << "lseek64 to " << srcoff << " got " << cpp_strerror(r) << dendl;
return r;
}
actual = ::lseek64(to, dstoff, SEEK_SET);
if (actual != (int64_t)srcoff) {
r = errno;
derr << "lseek64 to " << dstoff << " got " << cpp_strerror(r) << dendl;
return r;
}
loff_t pos = srcoff;
loff_t end = srcoff + len;