RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-04 10:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Division by zero in Legacy::encode_n()

Browse Source 
Fixes the Coverity Scan Report:
CID 1411820 (#1 of 1): Division or modulo by zero (DIVIDE_BY_ZERO)
9. divide_by_zero: In expression bl.length() * i / sum, division by expression sum which may be zero has undefined behavior.

Signed-off-by: Jos Collin <jcollin@redhat.com>
This commit is contained in:
Jos Collin 2017-06-24 20:59:43 +05:30
parent 3abb692384
commit 28cf5ac8b0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/test/test_denc.cc
View File

@ -613,6 +613,7 @@ bufferlist Legacy::encode_n(unsigned n, const vector<unsigned>& segments) {
auto p = bl.begin();
auto sum = std::accumulate(segments.begin(), segments.end(), 0u);
assert(sum != 0u);
for (auto i : segments) {
buffer::ptr seg;
p.copy_deep(bl.length() * i / sum, seg);