From 946a26c41e9f3a4f6d62fa3d1286c72985774c04 Mon Sep 17 00:00:00 2001 From: Afreen Date: Thu, 25 Jan 2024 16:51:06 +0530 Subject: [PATCH] mgr/dashboard: Code refactor rgw migrate component for using correctly the MIGRATE action verb fixes https://tracker.ceph.com/issues/64152 this.MIGRATE = $localize`Migrate to Multi-Site`; Just like other action verbs we should set this.Migrate = "MIGRATE" only. This will require rephrasing in the following places as well: 1. https://github.com/ceph/ceph/blob/d3256c484136a1b32b79a904861f681a9248ba3c/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-details/rgw-multisite-details.component.ts#L223-L228 2. https://github.com/ceph/ceph/blob/d3256c484136a1b32b79a904861f681a9248ba3c/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts#L180-L18 Signed-off-by: Afreen --- .../rgw-multisite-migrate/rgw-multisite-migrate.component.html | 2 +- .../rgw-multisite-migrate/rgw-multisite-migrate.component.ts | 2 +- .../frontend/src/app/shared/constants/app.constants.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.html index b18c5a0b9d7..51f72dd7f89 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.html @@ -146,7 +146,7 @@ diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts index 4c2f53b6af1..1073dee429a 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts @@ -181,7 +181,7 @@ export class RgwMultisiteMigrateComponent implements OnInit { () => { this.notificationService.show( NotificationType.success, - $localize`${this.actionLabels.MIGRATE} done successfully` + $localize`Migration done successfully` ); this.submitAction.emit(); this.activeModal.close(); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts index 0f41e283220..7edce5ff667 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts @@ -150,7 +150,7 @@ export class ActionLabelsI18n { this.IMPORT = $localize`Import`; - this.MIGRATE = $localize`Migrate to Multi-site`; + this.MIGRATE = $localize`Migrate`; /* Destroy an existing item */ this.DELETE = $localize`Delete`;