RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-03-06 00:10:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

config: Improve warning for unobserved value

Browse Source 
When a variable is not being observed we currently mark it
"unchangable". This can be misleading so try something hopefully a
little more informative.

Fixes: http://tracker.ceph.com/issues/18424
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
This commit is contained in:
Brad Hubbard 2017-01-05 12:45:01 +10:00
parent 0fb99b79b3
commit 1e8e754007
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qa/workunits/cephtool/test.sh
View File

@ -201,7 +201,7 @@ function test_mon_injectargs()
ceph tell osd.0 injectargs -- '--osd_op_history_duration'
ceph tell osd.0 injectargs -- '--mon-lease 6' >& $TMPFILE || return 1
check_response "mon_lease = '6' (unchangeable)"
check_response "mon_lease = '6' (not observed, change may require restart)"
# osd-scrub-auto-repair-num-errors is an OPT_U32, so -1 is not a valid setting
expect_false ceph tell osd.0 injectargs --osd-scrub-auto-repair-num-errors -1

2
src/common/config.cc
View File

@ -696,7 +696,7 @@ void md_config_t::_apply_changes(std::ostream *oss)
!_internal_field(key)) {
(*oss) << key << " = '" << buf << "' ";
if (range.first == range.second) {
(*oss) << "(unchangeable) ";
(*oss) << "(not observed, change may require restart) ";
}
}
for (obs_map_t::iterator r = range.first; r != range.second; ++r) {