RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-22 02:27:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

mgr: don't migrate config values that look like data

Browse Source 
A quickie heuristic, but sufficient to avoid picking
up e.g. SSL certs and trying to cram them into
config values.

Signed-off-by: John Spray <john.spray@redhat.com>
This commit is contained in:
John Spray 2018-04-16 05:39:03 -04:00
parent f2b340a842
commit 1d830df901
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/mgr/PyModuleRegistry.cc
View File

@ -410,6 +410,29 @@ void PyModuleRegistry::upgrade_config(
auto last_slash = i.first.rfind('/');
const std::string module_name = i.first.substr(4, i.first.substr(4).find('/'));
const std::string key = i.first.substr(last_slash + 1);
const auto &value = i.second;
// Heuristic to skip things that look more like stores
// than configs.
bool is_config = true;
for (const auto &c : value) {
if (c == '\n' || c == '\r' || c < 0x20) {
is_config = false;
break;
}
}
if (value.size() > 256) {
is_config = false;
}
if (!is_config) {
dout(1) << "Not migrating config module:key "
<< module_name << " : " << key << dendl;
continue;
}
module_config.set_config(monc, module_name, key, i.second);
dout(4) << "Rewrote configuration module:key "
<< module_name << ":" << key << dendl;