From 1c06642a729064f025d8d02ad0bea6ab804e5473 Mon Sep 17 00:00:00 2001 From: Tiago Melo Date: Fri, 3 Jul 2020 14:30:47 +0000 Subject: [PATCH] mgr/dashboard: Clean the output of lint and fix scripts Increase deprecation tslint rule from warning to error and remove no-use-before-declare. Fixes: https://tracker.ceph.com/issues/46339 Signed-off-by: Tiago Melo --- src/pybind/mgr/dashboard/frontend/package.json | 4 ++-- src/pybind/mgr/dashboard/frontend/tslint.json | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/package.json b/src/pybind/mgr/dashboard/frontend/package.json index ae40091954e..ef0e8078f75 100644 --- a/src/pybind/mgr/dashboard/frontend/package.json +++ b/src/pybind/mgr/dashboard/frontend/package.json @@ -27,12 +27,12 @@ "lint:html": "htmllint src/app/**/*.html && html-linter --config html-linter.config.json", "lint:tsc": "tsc -p src/tsconfig.app.json --noEmit && tsc -p tsconfig.spec.json --noEmit && tsc -p cypress/tsconfig.json --noEmit", "lint:scss": "stylelint '**/*.scss'", - "lint": "run-p --continue-on-error --aggregate-output lint:*", + "lint": "run-p -csl --aggregate-output lint:*", "fix:prettier": "prettier --write \"{src,cypress}/**/*.{ts,scss}\"", "fix:tslint": "npm run lint:tslint -- --fix", "fix:scss": "stylelint '**/*.scss' --fix", "fixmod": "pretty-quick --pattern \"{src,cypress}/**/*.{ts,scss}\" --branch HEAD", - "fix": "run-p --continue-on-error --aggregate-output fix:*", + "fix": "run-p -csl --aggregate-output fix:*", "fix:audit": "npx npm-force-resolutions", "compodoc": "compodoc", "doc-build": "compodoc -p src/tsconfig.app.json", diff --git a/src/pybind/mgr/dashboard/frontend/tslint.json b/src/pybind/mgr/dashboard/frontend/tslint.json index 4b14fc5c5f5..5136dc651af 100644 --- a/src/pybind/mgr/dashboard/frontend/tslint.json +++ b/src/pybind/mgr/dashboard/frontend/tslint.json @@ -8,7 +8,7 @@ "comment-format": [true, "check-space"], "curly": true, "deprecation": { - "severity": "warning" + "severity": "error" }, "eofline": true, "forin": true, @@ -44,7 +44,6 @@ "no-trailing-whitespace": true, "no-unnecessary-initializer": true, "no-unused-expression": true, - "no-use-before-declare": true, "no-var-keyword": true, "object-literal-sort-keys": false, "one-line": [true, "check-open-brace", "check-catch", "check-else", "check-whitespace"],