1
0
mirror of https://github.com/ceph/ceph synced 2025-02-17 07:57:44 +00:00

Fix casing of Content-Type header

It turns out, despite the HTTP spec declaring that header field names
should be case-insensitive, some clients treat them wrongly, and
consider "Content-type" to not match "Content-Type".

CyberDuck was one of those clients, now fixed upstream in
https://trac.cyberduck.io/ticket/8999

To reduce future occurances of this bug, fix the casing of the
Content-Type header, to strictly comply with the HTTP specification (be
strict about what you send, and generous about what you receive).

Fixes: 
Backport: infernalis, hammer, firefly
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
This commit is contained in:
Robin H. Johnson 2015-09-04 01:07:48 +00:00
parent 2d1d2efb1b
commit 1b9fbffdc2

View File

@ -557,7 +557,7 @@ void end_header(struct req_state *s, RGWOp *op, const char *content_type, const
int r;
if (content_type) {
r = s->cio->print("Content-type: %s\r\n", content_type);
r = s->cio->print("Content-Type: %s\r\n", content_type);
if (r < 0) {
ldout(s->cct, 0) << "ERROR: s->cio->print() returned err=" << r << dendl;
}