RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-03-06 00:10:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

ceph: propagate do_command()'s return value to user space

Browse Source 
We were returning '1' regardless of what do_command() returned in case
of error.  This would make building tools relying on command error codes
short of useless, and forced them to rely instead on error messages.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
(cherry picked from commit e91405d540)
This commit is contained in:
Joao Eduardo Luis 2013-03-28 02:07:18 +00:00 committed by Sage Weil
parent 807487c681
commit 06a1e9c0ec
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/tools/ceph.cc
View File

@ -337,8 +337,9 @@ int main(int argc, const char **argv)
}
bufferlist obl;
if (do_command(ctx, cmd, indata, obl) < 0) {
ret = 1;
ret = do_command(ctx, cmd, indata, obl);
if (ret < 0) {
ret = -ret;
break;
}
outbl.claim(obl);