RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-22 10:37:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

ceph-volume: make it possible to skip needs_root()

Browse Source 
Add the possibility to skip the `needs_root()` decorator.
See linked tracker for details.

Fixes: https://tracker.ceph.com/issues/53511

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This commit is contained in:
Guillaume Abrioux 2021-12-07 15:18:10 +01:00
parent 347d7d0f26
commit 068a1d2a30
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ceph-volume/ceph_volume/decorators.py
View File

@ -11,7 +11,7 @@ def needs_root(func):
""" """
@wraps(func) @wraps(func)
def is_root(*a, **kw): def is_root(*a, **kw):
if not os.getuid() == 0: if not os.getuid() == 0 and not os.environ.get('CEPH_VOLUME_SKIP_NEEDS_ROOT', False):
raise exceptions.SuperUserError() raise exceptions.SuperUserError()
return func(*a, **kw) return func(*a, **kw)
return is_root return is_root

7
src/ceph-volume/ceph_volume/tests/test_decorators.py
View File

@ -11,6 +11,13 @@ class TestNeedsRoot(object):
monkeypatch.setattr(decorators.os, 'getuid', lambda: 0) monkeypatch.setattr(decorators.os, 'getuid', lambda: 0)
assert decorators.needs_root(func)() is True assert decorators.needs_root(func)() is True
def test_is_not_root_env_var_skip_needs_root(self, monkeypatch):
def func():
return True
monkeypatch.setattr(decorators.os, 'getuid', lambda: 123)
monkeypatch.setattr(decorators.os, 'environ', {'CEPH_VOLUME_SKIP_NEEDS_ROOT': '1'})
assert decorators.needs_root(func)() is True
def test_is_not_root(self, monkeypatch): def test_is_not_root(self, monkeypatch):
def func(): def func():
return True # pragma: no cover return True # pragma: no cover