RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2024-12-18 09:25:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pipe: take a ref to existing while we are waiting

Browse Source 
Pipe: take a ref to existing while we are waiting

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
This commit is contained in:
Samuel Just 2016-05-18 10:35:23 -07:00
commit 040bccb49f
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/msg/simple/Pipe.cc
View File

@ -474,13 +474,21 @@ int Pipe::accept()
* held by somebody trying to make use of the SimpleMessenger lock.
* So drop locks, wait, and retry. It just looks like a slow network
* to everybody else.
*
* We take a ref to existing here since it might get reaped before we
* wake up (see bug #15870). We can be confident that it lived until
* locked it since we held the msgr lock from _lookup_pipe through to
* locking existing->lock and checking reader_dispatching.
*/
existing->get();
pipe_lock.Unlock();
msgr->lock.Unlock();
existing->notify_on_dispatch_done = true;
while (existing->reader_dispatching)
existing->cond.Wait(existing->pipe_lock);
existing->pipe_lock.Unlock();
existing->put();
existing = nullptr;
goto retry_existing_lookup;
}